linux-kernel - Re: radeonfb and X800 cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46560830.2000405@gmx.net>
Date:	Thu, 24 May 2007 23:48:32 +0200
From:	Jimmy Jazz <Jimmy.Jazz@....net>
To:	Luca Tettamanti <kronos.it@...il.com>
CC:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Daniel Drake <dsd@...too.org>,
	linux list <linux-kernel@...r.kernel.org>
Subject: Re: radeonfb and X800 cards

Luca Tettamanti a écrit :
> Il Sun, May 20, 2007 at 02:54:20PM +0200, Jimmy Jazz ha scritto: 
>> @Luca, if i remember well you have a X850, could you please try the
>> patch for me ?
> 
> It does work - sort of; BIOS parsing code is correct. It lacks the
> proper connector detection though (esp. port sharing). ATOM BIOS has a
> different data layout, so this should be added (now radeonfb thinks that
> I've 2 monitors).
> 
> I'll be away this weekend, so I'll try to come up with a patch as soon
> as I return home.
> 
> Luca

Hello,

The fact that you see two monitors doesn't really surprise me  :) .
Also, i'm convinced to move to the mega patch even if i'm not quite sure
all that code is also needed and I know it will unnecessarily increase
the size of the kernel. However, better have much then less. Sure, if
there were any more information on the web about video card
connector/port logic, my knowledge would have been undoubtedly improved.
Anyway, adding (conn->ddc_type == ddc_monid) in the if condition in
radeon_i2c.c works for me as well.

--- /usr/src/model_with-radeon-r400/aty/radeon_i2c.c	2007-04-13
13:35:49.000000000 +0200
+++ radeon_i2c.c	2007-04-13 22:07:16.000000000 +0200
@@ -163,7 +163,7 @@
 		mon_type = MT_NONE;
 		goto done;
 	}
-	if ((edid[EDID_STRUCT_DISPLAY] & 0x80) && (conn->ddc_type == ddc_dvi)) {
+	if ((edid[EDID_STRUCT_DISPLAY] & 0x80) && ((conn->ddc_type == ddc_dvi)
|| (conn->ddc_type == ddc_monid))) {
 		RTRACE("radeonfb: I2C (port %d) ... found TMDS panel\n", conn->ddc_type);
 		mon_type = MT_DFP;
 		goto done;

Thank you for testing the patch.

Jj
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/