linux-kernel - Re: PCI device problem - MMCONFIG, cannot allocate resource region, resource collisions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705232008.23540.jbarnes@virtuousgeek.org>
Date:	Wed, 23 May 2007 20:08:23 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Wayne Sherman <wsherman@...il.com>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	linux-kernel@...r.kernel.org
Subject: Re: PCI device problem - MMCONFIG, cannot allocate resource region, resource collisions

On Wednesday, May 23, 2007 5:20:46 Wayne Sherman wrote:
> Ivan Kokshaysky wrote:
> > No, it won't help. The 1M range (ff500000-ff5fffff) is more than enough.
>
> Good catch, I didn't look close enough at the allocations of the devices
> under the bridge.
>
> > The reason why the D-Link resource is not getting assigned is rather
> > interesting: as Wayne wrote
> >
> >> Here is the D-LINK NIC:
> >> # od -t x4 /sys/devices/pci0000:00/0000:00:14.4/0000:02:02.0/config
> >>
> >> 0000000 49011186 80b00117 00000011 00004010
> >
> > 			    ^^^^^^
> > which means that the device class is 0 (not defined).
> > And in drivers/pci/setup-bus.c we have
> >
> > 		/* Don't touch classless devices or host bridges or ioapics.  */
> > 		if (class == PCI_CLASS_NOT_DEFINED ||
> > 		    class == PCI_CLASS_BRIDGE_HOST)
> > 			continue;
> >
> > The short term fix would be to assign proper device class to D-Link NIC
> > using pci quirk...
>
> I would like to try this, where do I find "pci quirk"?

You'll need a patch roughly like this.  I'm not sure if it should be a header 
fixup or early fixup though...

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 65d6f23..801712f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1690,6 +1690,14 @@ static void __devinit quirk_p64h2_1k_io(struct pci_dev 
*dev)
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,	0x1460,		quirk_p64h2_1k_io);
 
+/* Give unknown D-Link network adapters a proper class */
+static void __devinit quirk_dlink_unknown(struct pci_dev *dev)
+{
+	if (dev->class = PCI_CLASS_UNKNOWN)
+		dev->class = PCI_CLASS_NETWORK_ETHERNET;
+}
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_DLINK, 0x4901, quirk_dlink_unknown);
+
 /* Fix the IOBL_ADR for 1k I/O space granularity on the Intel P64H2
  * The IOBL_ADR gets re-written to 4k boundaries in pci_setup_bridge()
  * in drivers/pci/setup-bus.c
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/