linux-kernel - Re: [patch] sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070525073957.GA15207@elte.hu>
Date:	Fri, 25 May 2007 09:39:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Satyam Sharma <satyam.sharma@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch] sched_clock(): cleanups


* Andi Kleen <andi@...stfloor.org> wrote:

> > if (!f)
> > 	f = cpufreq_get(freq->cpu);
> > if (!f)
> > 	f = tsc_khz;
> > 
> > ?
> > 
> > Something's not quite right here :-)
> 
> What do you think is wrong? cpufreq_get can return 0.
> 
> Admittedly the second test could be inside a block of the first, but 
> then it would make the code more ugly and this code is not performance 
> critical.

moving it inside the block makes the code _cleaner_ in fact :-)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/