linux-kernel - Re: [patch] x86_64: fix sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070525081653.GA24308@elte.hu>
Date:	Fri, 25 May 2007 10:16:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Satyam Sharma <satyam.sharma@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] x86_64: fix sched_clock()


* Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Fri, 2007-05-25 at 09:54 +0200, Ingo Molnar wrote:
> > Subject: [patch] x86_64: fix sched_clock()
> > From: Ingo Molnar <mingo@...e.hu>
> > 
> > sched_clock() is totally broken on x86_64, because it is not defined by 
> > the architecture at all! It fell the victim to the opaqueness of 
> > __attribute__((weak)) and to non-testing.
> > 
> > the i386 version was supposed to be used. This patch fixes that. Booted 
> > and tested on x86_64 and i386.
> > 
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> 
> This does indeed solve my issue.

great! Btw., this is also accidental proof that CFS works well even with 
a jiffies granularity sched_clock() ;-)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/