linux-kernel - Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 May 2007 10:22:48 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	Markus Rechberger <mrechberger@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	video4linux-list@...hat.com
Subject: Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

Jiri Slaby wrote:
> On 5/24/07, Markus Rechberger <mrechberger@...il.com> wrote:
>> On 5/24/07, Jiri Slaby <jirislaby@...il.com> wrote:
> [...]
>> > +static int stk1125_camera_asleep(struct stk11xx *dev)
>> > +{
>> > +     int value;
>> > +
>> > +     stk11xx_read_registry(dev, 0x0104, &value);
>> > +     stk11xx_read_registry(dev, 0x0105, &value);
>> > +     stk11xx_read_registry(dev, 0x0106, &value);
>> > +
>>
>> why do you read these values (this is also something in the ongoing
>> code I see, the read value just gets overwritten all the time)?
> 
> Well, as I tested, reads are neccesary, otherwise it doesn't work. And
> when they are needed, you need to read the value to some place in
> memory -- the &value.

Perhaps a few comments are warranted here and there about why some of
those less obvious things are done.

Or do it as more or less self-documenting code like

static inline void
stk11xx_unjam_registry(struct stk11xx *dev, u16 index)
{
	int dummy;

	stk11xx_read_registry(dev, index, &dummy);
}

-- 
Stefan Richter
-=====-=-=== -=-= ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/