linux-kernel - Re: Multiple free during oprofile unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070525161837.GA26105@redhat.com>
Date:	Fri, 25 May 2007 12:18:37 -0400
From:	Dave Jones <davej@...hat.com>
To:	Andi Kleen <ak@...ell.com>
Cc:	Chuck Ebbert <cebbert@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Multiple free during oprofile unload

On Fri, May 25, 2007 at 05:42:35PM +0200, Andi Kleen wrote:
 > 
 > >         for_each_possible_cpu(i) {
 > >                 kfree(cpu_msrs[i].counters);
 > >                 cpu_msrs[i].counters = NULL;
 > >                 kfree(cpu_msrs[i].controls);
 > >                 cpu_msrs[i].controls = NULL;
 > >         }
 > > 
 > > Seems the patch makes all the cpu_msrs[] point to the same area?
 > 
 > Yes I forgot to fix the free path. Will submit a patch.
 > 
 > BTW that is why I'm not so happy with you being so trigger happy with stable
 > submissions.

So what, the alternative is leave oprofile busted in 2.6.21.x even longer?

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/