linux-kernel - Re: [patch 4/7] ps3: Storage Driver Probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 May 2007 08:47:09 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linuxppc-dev@...abs.org, Geert.Uytterhoeven@...ycom.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 4/7] ps3: Storage Driver Probing

On Fri, 2007-05-25 at 18:18 +0200, Arnd Bergmann wrote:
> > +static u64 ps3stor_wait_for_completion(u64 devid, u64 tag,
> > +                                    unsigned int timeout)
> > +{
> > +     unsigned int retries = 0;
> > +     u64 res = -1, status;
> > +
> > +     for (retries = 0; retries < timeout; retries++) {
> > +             res =
> lv1_storage_check_async_status(NOTIFICATION_DEVID, tag,
> > +                                                  &status);
> > +             if (!res)
> > +                     break;
> > +             set_current_state(TASK_INTERRUPTIBLE);
> > +             schedule_timeout(1);
> > +     }
> 
> Any reason not to use msleep(1) instead of the schedule_timeout? 

Both look equally ugly though... do you really have to poll ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/