linux-kernel - Re: [patch] sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070525072512.GA12683@elte.hu>
Date:	Fri, 25 May 2007 09:25:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Satyam Sharma <satyam.sharma@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch] sched_clock(): cleanups


* Satyam Sharma <satyam.sharma@...il.com> wrote:

> Hi Ingo,
> 
> On 5/25/07, Ingo Molnar <mingo@...e.hu> wrote:
> >[...]
> >@@ -137,6 +147,7 @@ static void call_r_s_f(void *arg)
> > {
> >        struct cpufreq_freqs *freq = arg;
> >        unsigned f = freq->new;
> >+
> >        if (!f)
> >                f = cpufreq_get(freq->cpu);
> >        if (!f)
> 
> if (!f)
> 	f = cpufreq_get(freq->cpu);
> if (!f)
> 	f = tsc_khz;
> 
> ?
> 
> Something's not quite right here :-)

yeah, that looks like a real bug. When i looked at it during the cleanup 
i guess i got distracted by the descriptive function name of 
call_r_s_f() ... :-/

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/