linux-kernel - Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070526175947.7dffbec5@the-village.bc.nu>
Date:	Sat, 26 May 2007 17:59:47 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Junio C Hamano <junkio@....net>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, bzolnier@...il.com,
	linux-ide@...r.kernel.org, Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 2/3] Unify dma blacklist in ide-dma.c and libata-core.c

On Mon, 21 May 2007 22:06:36 -0700
Junio C Hamano <junkio@....net> wrote:

> This introduces a shared header file that defines the entries
> for two dma blacklists in ide-dma.c and libata-core.c to make it
> easier to keep them in sync.
> 
> Signed-off-by: Junio C Hamano <junkio@....net>

NAK

This makes stuff so much more ugly its not funny

> ---
> 
>  * Removes more lines than it adds.  I am not proud of the
>    DMA_BLACK_LIST macro in ide-dma.c which relies on the
>    compiler doing a sane thing for compile time constant
>    expression to initialize the list, but that hopefully can be
>    fixed in the next patch.

The basic concept is sound but it would be better to make sure
the ATA_HORKAGE macros and struct ata_blacklist_entry as well as all the
blacklist stuff was placed together in one file to avoid the horrors you
are proposing and then used by both driver sets.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/