linux-kernel - Re: [git patches] libata fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 May 2007 20:15:20 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Mikael Pettersson <mikpe@...uu.se>
CC:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@....linux.org.uk>
Subject: Re: [git patches] libata fixes

Mikael Pettersson wrote:
> On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote:
>> Jeff Garzik (4):
>>      [libata] sata_promise: fix flags typo
> ...
>> --- a/drivers/ata/sata_promise.c
>> +++ b/drivers/ata/sata_promise.c
>> @@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = {
>>
>> 	/* board_2057x_pata */
>> 	{
>> -		.flags		= PDC_COMMON_FLAGS | ATA_FLAG_SLAVE_POSS,
>> +		.flags		= PDC_COMMON_FLAGS | ATA_FLAG_SLAVE_POSS |
>> 				  PDC_FLAG_GEN_II,
>> 		.pio_mask	= 0x1f, /* pio0-4 */
>> 		.mwdma_mask	= 0x07, /* mwdma0-2 */
> 
> Acked-by: Mikael Pettersson <mikpe@...uu.se>
> 
> Good catch. This typo would have prevented pdc_host_intr()
> from detecting GEN_II-specific errors on the PATA port.

Oops -- I should have credited Al Viro for the catch, in the changelog.

This email hereby corrects the record :)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/