linux-kernel - Re: software suspend doesn't work with 2.6.22-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1180173233.9773.79.camel@nigel.suspend2.net>
Date:	Sat, 26 May 2007 19:53:53 +1000
From:	Nigel Cunningham <nigel@...el.suspend2.net>
To:	Maximilian Engelhardt <maxi@...monizer.de>,
	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: software suspend doesn't work with 2.6.22-rc3

Hi.

On Sat, 2007-05-26 at 11:28 +0200, Maximilian Engelhardt wrote:
> Hello,
> 
> When I try software suspend on my laptop it always returns to my running 
> system after some time.
> This is what's logged by the kernel:
> 
> swsusp: Basic memory bitmaps created
> Stopping tasks ... 
> Stopping kernel threads timed out after 20 seconds (1 tasks refusing to 
> freeze):
>  cryptd
> Restarting tasks ... done.
> swsusp: Basic memory bitmaps freed
> 
> I have no idea what's the problem, but if you tell me what I should do I can 
> create debugging information and/or test patches.

Could you try this patch, please? It should help.

Herbert, is this right? If cryptd is going to be used for block devs,
the task should probably be PF_NOFREEZE (or whatever it is today)
instead.

Regards,

Nigel

 crypto/cryptd.c         |    1 +
 include/linux/freezer.h |    3 +++
 kernel/power/process.c  |    2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)
diff -ruNp 991-fix-cryptd.patch-old/crypto/cryptd.c 991-fix-cryptd.patch-new/crypto/cryptd.c
--- 991-fix-cryptd.patch-old/crypto/cryptd.c	2007-05-19 18:16:47.000000000 +1000
+++ 991-fix-cryptd.patch-new/crypto/cryptd.c	2007-05-26 19:45:42.000000000 +1000
@@ -341,6 +341,7 @@ static int cryptd_thread(void *data)
 
 		mutex_unlock(&state->mutex);
 
+		try_to_freeze();
 		schedule();
 	} while (!stop);
 


Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)