linux-kernel - Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070528103011.GC18807@elf.ucw.cz>
Date:	Mon, 28 May 2007 12:30:11 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Gautham R Shenoy <ego@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Nigel Cunningham <nigel@...el.suspend2.net>,
	Oleg Nesterov <oleg@...sign.ru>,
	Maximilian Engelhardt <maxi@...monizer.de>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

Hi!

> > This patch is on top of the "Freezer: Avoid freezing kernel threads prematurely"
> > patch that I posted yestarday, available at http://lkml.org/lkml/2007/5/25/199
> > (updated version that applies cleanly on top of 2.6.22-rc3, is available at
> > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc3/patches/07-freezer-avoid-freezing-kernel-threads-prematurely.patch).
> > It has been tested on a couple of machines and doesn't seem to break anything.
> > 
> > [As you can see there are quite a lot of files affected, so I didn't add all
> > maintainers of them to the CC list.  In fact, I'm not sure how to handle
> > notifying them of the change, so please advise.]
> 
> Does the lack of comments mean that everyone on the CC list agrees with this
> approach? ;-)
> 
> In the meantime, it turns out that this patch fixes the hibernation/suspend
> problem with cryptd discussed in the thread at
> http://lkml.org/lkml/2007/5/26/24 .
> 
> The problem is that cryptd doesn't call try_to_freeze() and doesn't set
> PF_NOFREEZE for itself, so the freezer cannot handle it properly.  In principle
> we can add either try_to_freeze() or the setting of PF_NOFREEZE to it, but if
> the approach in the $subject patch is acceptable, we'll need to remove that
> soon.  So, what should we do?

I'd add PF_NONFREEZE. Changing the defaults in freezer is obviously
not 2.6.22 material.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/