[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070528200434.GC31233@uranus.ravnborg.org>
Date: Mon, 28 May 2007 22:04:34 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Andi Kleen <ak@...e.de>
Cc: Indan Zupancic <indan@....nu>,
Jeremy Fitzhardinge <jeremy@...p.org>,
Andrey Borzenkov <arvidjaar@...l.ru>,
linux-kernel@...r.kernel.org, Bernhard Walle <bwalle@...e.de>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] x86: fix section mismatch warnings in mtrr
On Sun, May 27, 2007 at 11:56:21AM +0200, Andi Kleen wrote:
>
> >
> > So section mismatch warnings are more about catching sloopy usage of __init than it is to
> > catch potential kernel oopesen. But the latter is a nice side effect that is appreciated.
>
> My point was that I cannot recall a single real oops bug found by the compile
> time checking.
>
> We had a few in the past, but since we poison init data after boot they all tended
> to be found quickly anyways.
It's far better to find the bugs during build time than during run-time.
> But the warnings just seem to require endless changes and bogus changes
> (randomly moving code which was actually ok because it only called
> in the init case).
The main culprint is probarly that the warnings are so vocal.
Everyone see them for each kernel-build that touches one file.
And then everyone and their cousin try to fix them.
When we are down to a warning-free x86 build things will start to look different.
And I will do my to make us get there - as time permits.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists