linux-kernel - Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070529134134.GA11026@zhen-devel.sh.intel.com>
Date:	Tue, 29 May 2007 21:41:34 +0800
From:	Wang Zhenyu <zhenyu.z.wang@...el.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Dave Jones <davej@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Keith Packard <keithp@...thp.com>,
	Eric Anholt <eric@...olt.net>
Subject: Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe

On 2007.05.29 10:18:48 +0000, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote:
> > +static const struct intel_driver_description {
> > +	unsigned int chip_id;
> > +	unsigned int gmch_chip_id;
> > +	char *name;
> > +	struct agp_bridge_driver *driver;
> > +	struct agp_bridge_driver *gmch_driver;
> 
> The two should be const to avoid the silly casts below.
> 
> > +	for (i = 0; intel_agp_chipsets[i].name != NULL; i++) {
> > +		if (pdev->device == intel_agp_chipsets[i].chip_id)
> > +		    break;
> 
> please use tabs for indentation.
> 

I'll fix those problems in next submit, thank you for review. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/