linux-kernel - Re: [PATCH] add a trivial patch style checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B907D7E4-D348-4795-9B55-74F7392F548C@ac.upc.edu>
Date:	Tue, 29 May 2007 18:20:54 +0200
From:	"Julio M. Merino Vidal" <jmerino@...upc.edu>
To:	Joel Schopp <jschopp@...tin.ibm.com>
Cc:	Andy Whitcroft <apw@...dowen.org>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Andrew Morton <akpm@...l.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker

On 29/05/2007, at 18:12, Joel Schopp wrote:

>>>> +		if(!($prevline=~/\/\*\*/) && length($lineforcounting) > 80){
>>> Actually, I think this should be "> 79" (after stripping a .diff's
>>> control column), since the cursor may move to the 81th column when
>>> editing an 80-col line - which is what we want to avoid, no?
>> 80 tends to work for me because of that "if on 80 then don't wrap  
>> until
>> there is another character" behaviour of most terminals.  Anyone else
>> with a firm opinion.
>
> I think 80 is good.  What the specific number is does not matter  
> much, we all have screens wider than 80 characters.  The point is  
> just to have a number that prevents really long lines and prevents  
> people from indenting too many levels past our minds ability to  
> keep up.  We've already all been coding to 80, and it happens to be  
> a nice round number we can all remember and love.  The only reason  
> I see to select 79 is that prime numbers are generally cooler than  
> other numbers.

We do have screens wider than 80 characters, but almost all the time  
I spend in terminal windows, they are set to 24x80 (the default  
size).  It is a matter of habit, and I bet I'm not alone.  Hence, 80  
is "annoying" not only because patches will wrap, but also because in  
some editors the 80th character will also wrap.

Just my 2 cents,

-- 
Julio M. Merino Vidal <jmerino@...upc.edu>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/