[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.61.0705292218520.11140@yvahk01.tjqt.qr>
Date: Tue, 29 May 2007 22:22:43 +0200 (MEST)
From: Jan Engelhardt <jengelh@...ux01.gwdg.de>
To: Andy Whitcroft <apw@...dowen.org>
cc: Andi Kleen <andi@...stfloor.org>, Andrew Morton <akpm@...l.org>,
Randy Dunlap <rdunlap@...otime.net>,
Joel Schopp <jschopp@...tin.ibm.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker
On May 29 2007 10:05, Andy Whitcroft wrote:
>
>>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>>> + print "Gotos should not be indented\n";
>>> + print "$herecurr";
>>> + $clean = 0;
>>> + }
>>
>> emacs generates one space label in front of a goto label. I wouldn't
>> outlaw this.
>
>Yep, we also now allow one space something to do with diff -p not
>getting confused...
Not only diff and emacs. At least joe (joe.sf.net) is another editor
whose %y tag or so also takes lines with
no space at the front and properly paired parens,braces,etc.
as key lines for %y. Since usually, functions are the only thing at
the beginning of a line, this works well. That's why labels should
be allowed to be indented by one.
Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists