linux-kernel - Re: [PATCH] Samsung LTV350QV LCD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1180472477.5822.87.camel@localhost.localdomain>
Date:	Tue, 29 May 2007 22:01:17 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Haavard Skinnemoen <hskinnemoen@...el.com>
Cc:	David Brownell <david-b@...bell.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Samsung LTV350QV LCD driver

On Tue, 2007-05-29 at 21:52 +0200, Haavard Skinnemoen wrote:
> This patch adds support for powering on and off the Samsung LTV350QV
> LCD panel via SPI. The driver responds to framebuffer power
> management, it powers off the panel on reboot/halt/poweroff, and it
> can also be controlled through sysfs. The panel is powered up when the
> module is loaded and off when the module is unloaded.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@...el.com>

The LCD class device bits look fine to me. The only change I'd request
is not to change the order of things in drivers/video/backlight/Kconfig.
If you do want to reword one of those entries (which is what I think you
wanted to do), send it as a separate patch please.

David, any objections to the SPI bits?

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/