| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070530074235.GA28866@nostromo.devel.redhat.com>
Date: Wed, 30 May 2007 03:42:35 -0400
From: Bill Nottingham <notting@...hat.com>
To: linux-kernel@...r.kernel.org
Subject: [PATCH] mm: fix comparisons against unsigned
Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0.
Signed-off-by: Bill Nottingham <notting@...hat.com>
---
filemap.c | 34 ++++++++++++++++------------------
slub.c | 2 --
2 files changed, 16 insertions(+), 20 deletions(-)
Patch is noisy due to whitespace.
diff -ru linux-2.6.21-old/mm/filemap.c linux-2.6.21/mm/filemap.c
--- linux-2.6.21-old/mm/filemap.c 2007-05-30 02:53:04.000000000 -0400
+++ linux-2.6.21/mm/filemap.c 2007-05-30 01:43:30.000000000 -0400
@@ -2176,24 +2176,22 @@
continue;
}
zero_length_segment:
- if (likely(copied >= 0)) {
- if (!status)
- status = copied;
-
- if (status >= 0) {
- written += status;
- count -= status;
- pos += status;
- buf += status;
- if (unlikely(nr_segs > 1)) {
- filemap_set_next_iovec(&cur_iov,
- &iov_base, status);
- if (count)
- buf = cur_iov->iov_base +
- iov_base;
- } else {
- iov_base += status;
- }
+ if (!status)
+ status = copied;
+
+ if (status >= 0) {
+ written += status;
+ count -= status;
+ pos += status;
+ buf += status;
+ if (unlikely(nr_segs > 1)) {
+ filemap_set_next_iovec(&cur_iov,
+ &iov_base, status);
+ if (count)
+ buf = cur_iov->iov_base +
+ iov_base;
+ } else {
+ iov_base += status;
}
}
if (unlikely(copied != bytes))
diff -ru linux-2.6.21-old/mm/slub.c linux-2.6.21/mm/slub.c
--- linux-2.6.21-old/mm/slub.c 2007-05-30 02:53:06.000000000 -0400
+++ linux-2.6.21/mm/slub.c 2007-05-30 01:45:33.000000000 -0400
@@ -1966,8 +1966,6 @@
s->size = size;
s->order = calculate_order(size);
- if (s->order < 0)
- return 0;
/*
* Determine the number of objects per slab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists