[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070530101348.GD24586@lst.de>
Date: Wed, 30 May 2007 12:13:49 +0200
From: Christoph Hellwig <hch@....de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Cc: Christoph Hellwig <hch@....de>, linuxppc-dev@...abs.org,
linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [patch 6/7] ps3: ROM Storage Driver
On Tue, May 29, 2007 at 01:11:41PM +0200, Geert Uytterhoeven wrote:
> > This looks very inefficient. Just set sg_tablesize of your driver
> > to 1 to avoid getting mutiple segments.
>
> The disadvantage of setting sg_tablesize = 1 is that the driver will get small
> requests (PAGE_SIZE) most of the time, which is very bad for performance.
If you set .clustering = 1 in your host template you will frequently
get larger requests.
For any sane hypervisor or hardware the copy should be worth
than that. Then again a sane hardware or hypervisor would support
SG requests..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists