linux-kernel - Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070530112946.GT3899@stusta.de>
Date:	Wed, 30 May 2007 13:29:46 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux-kernel@...r.kernel.org, Josh Boyer <jwboyer@...il.com>,
	"Robert P. J. Day" <rpjday@...dspring.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from
	inodes_stat_t.

On Wed, May 30, 2007 at 08:41:56AM +0200, Stefan Richter wrote:
> From: Stefan Richter <stefanr@...6.in-berlin.de>
> Subject: fs: clarify "dummy" member in struct inodes_stat_t
> 
> Found by Robert P. J. Day:  The role of inodes_stat_t.dummy wasn't clear
> and one might be tempted to remove it.  Give it a better name and add a
> comment.
> 
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
> ---
> Only quickly compile-tested.
> 
> Index: linux/include/linux/fs.h
> ===================================================================
> --- linux.orig/include/linux/fs.h
> +++ linux/include/linux/fs.h
> @@ -44,7 +44,7 @@ extern int get_max_files(void);
>  struct inodes_stat_t {
>  	int nr_inodes;
>  	int nr_unused;
> -	int dummy[5];
> +	int reserved[5];	/* for sysctl and procfs ABI compatibility */
>  };
>  extern struct inodes_stat_t inodes_stat;

Considering that we export this struct to usespace, I don't think 
renaming a member without a good reason is a good idea (but adding a 
comment makes sense).

> Stefan Richter

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/