| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 May 2007 13:47:44 +0200 From: Jiri Slaby <jirislaby@...il.com> To: Takashi Iwai <tiwai@...e.de> CC: Bill Nottingham <notting@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] alsa: fix comparison of unsigned < 0 Takashi Iwai napsal(a): > Hi, > > thanks for checking this. > They seem actually hitting some real bugs. Bug fixes are ok, but keep on your mind this (I haven't checked if this is the case): http://lkml.org/lkml/2006/11/28/206 > At Wed, 30 May 2007 03:35:54 -0400, > Bill Nottingham wrote: >> diff -ru linux-2.6.21-old/sound/pci/ac97/ac97_patch.c linux-2.6.21/sound/pci/ac97/ac97_patch.c >> --- linux-2.6.21-old/sound/pci/ac97/ac97_patch.c 2007-05-30 02:53:05.000000000 -0400 >> +++ linux-2.6.21/sound/pci/ac97/ac97_patch.c 2007-05-30 02:32:41.000000000 -0400 >> @@ -2086,8 +2086,7 @@ >> struct snd_ac97 *ac97 = snd_kcontrol_chip(kcontrol); >> unsigned short val; >> >> - if (ucontrol->value.enumerated.item[0] > 3 >> - || ucontrol->value.enumerated.item[0] < 0) >> + if (ucontrol->value.enumerated.item[0] > 3) >> return -EINVAL; >> val = ctrl2reg[ucontrol->value.enumerated.item[0]] >> << AC97_AD198X_VREF_SHIFT; > > This one is fine. [...] regards, -- http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists