linux-kernel - Re: [RFC] LZO de/compression support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0705300724k533029cei97033425f12b5b37@mail.gmail.com>
Date:	Wed, 30 May 2007 19:54:43 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Johannes Stezenbach" <js@...uxtv.org>
Cc:	"Nitin Gupta" <nitingupta910@...il.com>,
	"Adrian Bunk" <bunk@...sta.de>,
	"Jan Engelhardt" <jengelh@...ux01.gwdg.de>,
	"Daniel Hazelton" <dhazelton@...er.net>,
	lkml <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Richard Purdie" <richard@...nedhand.com>,
	"Bret Towe" <magnade@...il.com>
Subject: Re: [RFC] LZO de/compression support - take 6

On 5/30/07, Johannes Stezenbach <js@...uxtv.org> wrote:
> On Wed, May 30, 2007, Nitin Gupta wrote:
> >
> > Again, all the original code has been retained _as-is_. Whatever was
> > changed, has been mentioned in that detailed changelog that I post
> > along with patch.
>
> Just a general remark (I haven't been following this thread closely):
>
> IMHO it would be _much_ better to merge the original code and
> your changes as seperate patches. Then someone who
> wants to review it later doesn't have to jump through all
> the hoops of finding the original code himself to diff it
> and see your changes.
>
> Additionally, you should also split stylistic/cleanup
> changes like "Reformatted the code to match general kernel style"
> from functional changes like "use cpu_to_le16()".
>
> Ideally each of the changes you mention in your
> "Changelog vs. original LZO" should be a seperate
> patch, this would make review much easier.

I violently agree with this method of going forward.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/