[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d120d5000705300756t24d4a58ey1f4130bef22f8309@mail.gmail.com>
Date: Wed, 30 May 2007 10:56:28 -0400
From: "Dmitry Torokhov" <dmitry.torokhov@...il.com>
To: "Richard Purdie" <rpurdie@...ys.net>
Cc: "Jan Kratochvil" <honza@...os.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Support for controlling leds on xbox 360 pad.
On 5/29/07, Richard Purdie <rpurdie@...ys.net> wrote:
> On Tue, 2007-05-29 at 23:29 +0200, Jan Kratochvil wrote:
> >
> > I have the impression that the led subsystem doesn't actually count with
> > possibility to have more then one device of one type, right? In my case there
> > can by lots of pads, so I made it on my own, using counter. Is it ok?
>
> It leaves it up to the driver concerned. In your case it makes sense so
> counting is fine. Don't put the colon in though, just have it as xpad0
> etc. as the name. Anything after the first colon is defined as an
> optional colour (see Documentation/leds-class.txt).
>
Richard,
Do you think it makes sense to split the driver (and Kconfig options)
between input and leds directories as Jan had done? I know that I
prefer to keep anything input related in input directory because it
makes my life as maintainer easier and I bet you prefer the same but
it does not always work well for multifunction devices or devices
using several subsystems...
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists