linux-kernel - Re: [PATCH] add a trivial patch style checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0705301800330.11140@yvahk01.tjqt.qr>
Date:	Wed, 30 May 2007 18:04:27 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Andy Whitcroft <apw@...dowen.org>,
	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...l.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add a trivial patch style checker


On May 30 2007 08:33, Randy Dunlap wrote:
>> > That's just a joe bug then.
>> > 
>> > diff no longer requires a beginning space, at least in the testing
>> > that I did it worked with no leading space on a label:.
>> 
>> But not everyone runs the latest and greatest. diffutils 2.8.7
>> takes /^label:/ as a marker for the @@ line.
>
> OK.  What does "marker for the @@ line" mean?

if ($_ !~ /^[\(\[\{]/ && $_ =~ /^(\S+)/) {
    print "@@ -a,b +c,d @@ $1\n"
}

So
label:
will be the 'mark[er]' for the @@ line

Just try yourself:
<<< foo.c <<<
int main(void)
{
	x
	y
	z
label:
	a
	b
	c
	d
	e
	f
}
>>>
<<< foo2.c <<<
int main(void)
{
	x
	y
	z
label:
	a
	b
	c
	d
	d+
	e
	f
}
>>>
<<< diff -dpru foo.c foo2.c <<<
--- foo.c       2007-05-30 10:33:45.714222656 +0200
+++ foo2.c      2007-05-30 18:03:43.061471495 +0200
@@ -8,6 +8,7 @@ label:
 	b
 	c
 	d
+	d+
 	e
 	f
 }
>>>

	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/