linux-kernel - Re: [-mm] Move zlib compression library to common directory [TAKE TWO]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 May 2007 23:35:17 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Michael-Luke Jones" <mike.luke.jones@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	dwmw2@...radead.org, "Mark Adler" <madler@...mni.caltech.edu>,
	jloup@...p.org
Subject: Re: [-mm] Move zlib compression library to common directory [TAKE TWO]

Hi Michael,

On 5/29/07, Michael-Luke Jones <mike.luke.jones@...il.com> wrote:
>
>
> This patch moves the zlib compression and decompression code
> to a common directory. The zutil.h header, which is not meant
> to be public, is moved from include/linux/ to lib/zlib/.

You could remove the (now pointless) /* WARNING: ... */ comment
from (the now truly private) zutil.h too ...

> In addition, the PRESET_DICT definition from zutil.h, used by
> fs/jffs2/compr_zlib.c is moved to the 'true' public zlib
> header include/linux/zlib.h.

Ugh, I wish you had held on from this patch till the original thread
discussing this reached some conclusion ... from Mark's response
there it does seem PRESET_DICT is clearly an implementation
(and not interface) detail -- which means to me that it must continue
to live in zutil.h (the private header) ... but then, this change is
clearly not so critical either, so it doesn't matter much, I guess.

[ Added zlib authors Mark Adler and Jean-Loup Gailly on this
thread too. ]

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/