linux-kernel - Re: dealing with gcc 'comparison is always false' warnings (was: [PATCH] drivers/infiniband: fix comparsion between unsigned and negative)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070530190937.GA5444@nostromo.devel.redhat.com>
Date:	Wed, 30 May 2007 15:09:37 -0400
From:	Bill Nottingham <notting@...hat.com>
To:	Satyam Sharma <satyam.sharma@...il.com>
Cc:	Roland Dreier <rdreier@...co.com>, openib-general@...nib.org,
	linux-kernel@...r.kernel.org
Subject: Re: dealing with gcc 'comparison is always false' warnings (was:
	[PATCH] drivers/infiniband: fix comparsion between unsigned and
	negative)

Satyam Sharma (satyam.sharma@...il.com) said: 
> But yes, the kind of "fixes" you pointed out that _remove_ these conditions
> are definitely *not* what we would want to do.

I can see that - but I think it should be at least be brought up for each
warning, to determine either:

1) if it should be ignored
2) if a signed type is actually intended
3) if the code should be elided

While not necessarily in the IB instances, there are cases where there
are entire blocks of code (with debugging output, error returns, etc)
that can never get run, and it may make sense to remove those.

Bill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/