linux-kernel - Re: [trivial PATCH, updated] fs: clarify "dummy" member in struct inodes_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <465DCD9A.5030003@oracle.com>
Date:	Wed, 30 May 2007 12:16:42 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	trivial@...nel.org, Adrian Bunk <bunk@...sta.de>,
	linux-kernel@...r.kernel.org, Josh Boyer <jwboyer@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Alexey Dobriyan <adobriyan@...il.com>,
	"Robert P. J. Day" <rpjday@...dspring.com>
Subject: Re: [trivial PATCH, updated] fs: clarify "dummy" member in struct
 inodes_stat_t

Stefan Richter wrote:
> On 30 May, Robert P. J. Day wrote:
>> On Wed, 30 May 2007, Adrian Bunk wrote:
>>> Considering that we export this struct to usespace, I don't think
>>> renaming a member without a good reason is a good idea (but adding a
>>> comment makes sense).
> [...]
>> i thought i was submitting a fairly innocuous patch.  live and learn.
> 
> I've could have seen that it is defined outside #ifdef __KERNEL__.
> 
> 
> From: Stefan Richter <stefanr@...6.in-berlin.de>
> Subject: fs: clarify "dummy" member in struct inodes_stat_t

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
> --- linux.orig/include/linux/fs.h
> +++ linux/include/linux/fs.h
> @@ -44,7 +44,7 @@ extern int get_max_files(void);
>  struct inodes_stat_t {
>  	int nr_inodes;
>  	int nr_unused;
> -	int dummy[5];
> +	int dummy[5];		/* padding for sysctl ABI compatibility */
>  };
>  extern struct inodes_stat_t inodes_stat;
>  
> 


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/