[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200705302348.54259.arnd@arndb.de>
Date: Wed, 30 May 2007 23:48:53 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Chris Wedgwood <cw@...f.org>
Cc: Michal Marek <mmarek@...e.cz>, xfs@....sgi.com,
linux-kernel@...r.kernel.org
Subject: Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode
On Wednesday 30 May 2007, Chris Wedgwood wrote:
>
> On Wed, May 30, 2007 at 02:59:55PM +0200, Michal Marek wrote:
>
> > +typedef struct xfs_fsop_geom_v132 {
>
> wouldn't xfs_fsop_geom_v1_32
> ^
>
> > + __u32 blocksize; /* filesystem (data) block size */
>
> [...]
>
> > + __u32 dirblocksize; /* directory block size, bytes */
> > +} __attribute__((packed)) xfs_fsop_geom_v132_t;
>
> and xfs_fsop_geom_v1_32_t
> ^
>
> read better there?
Actually, the current convention would be struct compat_xfs_fsop_geom_v1
and compat_xfs_fsop_geom_v1_t.
Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists