[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <465DF2A2.2070801@oracle.com>
Date: Wed, 30 May 2007 14:54:42 -0700
From: Randy Dunlap <randy.dunlap@...cle.com>
To: Christoph Lameter <clameter@....com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3 -mm] slub: use lib/hexdump
Christoph Lameter wrote:
> On Wed, 30 May 2007, Randy Dunlap wrote:
>
>>> I'd like to keep print_section around as it also does some other things.
>>> Repeating the output formatting at the various call locations will make
>>> it difficult to change if you add another whizbang feature.
>> I have no problems with keeping print_section() except that it's not used
>> in the current tree after this patch. :)
>>
>>> I have a patch here that I could sent out today if hexdump would work the
>>> right way.
>> Please define "the right way."
>
> Align the ascii output so that it does not look that ugly.
It's a kernel log file, for crying out loud. It is not formatted.
but I'll change it :(
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists