linux-kernel - Re: [PATCH 1/3] hexdump: more output formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <465E02FC.3030201@oracle.com>
Date:	Wed, 30 May 2007 16:04:28 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jesper Juhl <jesper.juhl@...il.com>
CC:	Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, hugh@...itas.com
Subject: Re: [PATCH 1/3] hexdump: more output formatting

Jesper Juhl wrote:
> On 30/05/07, Randy Dunlap <randy.dunlap@...cle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
> 
> Some friendly nitpicking below :-)
> 
>> Add a prefix string parameter.  Callers are responsible for any
>> string length/alignment that they want to see in the output.  I.e.,
>> callers should pad strings to achieve alignment if they want that.
>>
>> Add rowsize parameter.  This is the number of raw data bytes
>> to be printed per line.  Must be 16 or 32.
>>
>> Add a group_size parameter.  This allows callers to dump values
> 
> One is called "rowsize" the other "group_size". How about consistent
> naming; either "row_size" and "group_size" or "rowsize" and
> "groupsize" ?

Done.  but please don't add that to CodingStyle.

>> as 1-byte, 2-byte, 4-byte, or 8-byte numbers.  Default is
>> 1-byte numbers.  If the total length is not an even multiple
>> of group_size, 1-byte numbers are printed.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/