linux-kernel - Re: [patch] Introduce CONFIG_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070531085307.15a9bbc8@gondolin.boeblingen.de.ibm.com>
Date:	Thu, 31 May 2007 08:53:07 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	"Williams, Dan J" <dan.j.williams@...el.com>
Cc:	"Heiko Carstens" <heiko.carstens@...ibm.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"John W. Linville" <linville@...driver.com>,
	"Kyle McMartin" <kyle@...isc-linux.org>,
	<linux-kernel@...r.kernel.org>, <James.Bottomley@...eleye.com>,
	"Tejun Heo" <htejun@...il.com>, "Jeff Garzik" <jeff@...zik.org>,
	"Martin Schwidefsky" <schwidefsky@...ibm.com>,
	<geert@...ux-m68k.org>, <zippel@...ux-m68k.org>, <spyro@....com>,
	<uclinux-v850@....nec.co.jp>, <ysato@...rs.sourceforge.jp>
Subject: Re: [patch] Introduce CONFIG_HAS_DMA.

On Wed, 30 May 2007 14:40:02 -0700,
"Williams, Dan J" <dan.j.williams@...el.com> wrote:

> With the patch non-dma-architectures that try to build code with true
> dependencies on the DMA api will fail to link i.e.:
> 
> CONFIG_DMA_ENGINE=y CONFIG_HAS_DMA=n ASYNC_MEMCPY=y
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> async_tx/built-in.o: In function `async_memcpy':
> xor.c:(.text+0x770): undefined reference to `dma_map_page'
> xor.c:(.text+0x798): undefined reference to `dma_map_page'
> xor.c:(.text+0x968): undefined reference to `dma_map_page'
> 
> Now changing CONFIG_DMA_ENGINE to depend on HAS_DMA (which is more
> correct than saying !S390). 

Makes sense.

> Results in:
> CONFIG_DMA_ENGINE=n CONFIG_HAS_DMA=n ASYNC_MEMCPY=y
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
>   KSYM    .tmp_kallsyms1.S
>   AS      .tmp_kallsyms1.o
>   LD      .tmp_vmlinux2
>   KSYM    .tmp_kallsyms2.S
>   AS      .tmp_kallsyms2.o
>   LD      vmlinux
> 
> This also allows include/asm-s390/dma-mapping.h to be dropped.

Cool. Thanks for looking into that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/