linux-kernel - Re: [PATCH] sendfile removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070531124753.a99f713c.dada1@cosmosbay.com>
Date:	Thu, 31 May 2007 12:47:53 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-kernel@...r.kernel.org, cotte@...ibm.com, hugh@...itas.com,
	neilb@...e.de, zanussi@...ibm.com,
	Linus Torvalds <torvalds@...l.org>, hch@...radead.org
Subject: Re: [PATCH] sendfile removal

On Thu, 31 May 2007 12:33:16 +0200
Jens Axboe <jens.axboe@...cle.com> wrote:

> Hi,
> 
> This patch removes the ->sendfile() hook from the file_operations
> structure, and replaces the sys_sendfile() mechanism to be based on
> ->splice_read() instead. There should be no functional changes.
> 
  
> -	retval = in_file->f_op->sendfile(in_file, ppos, count, file_send_actor, out_file);
> +	fl = 0;
> +	if (in_file->f_flags & O_NONBLOCK)
> +		fl = SPLICE_F_NONBLOCK;
> +
> +	retval = do_splice_direct(in_file, ppos, out_file, count, fl);

I like this, but are you sure it wont break user land ?

Some applications might react badly if sendfile() returns EAGAIN ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/