linux-kernel - Re: [PATCH] drivers/block/ub.c: use list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070530170530.08a77359.zaitcev@redhat.com>
Date:	Wed, 30 May 2007 17:05:30 -0700
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	"Satyam Sharma" <satyam.sharma@...il.com>,
	"Matthias Kaehlcke" <matthias.kaehlcke@...il.com>,
	linux-usb-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, zaitcev@...hat.com
Subject: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

On Wed, 30 May 2007 16:42:41 -0700, Roland Dreier <rdreier@...co.com> wrote:

> If I just see
> 
> 	for (pos = list_entry((head)->next, typeof(*pos), member),
> 		n = list_entry(pos->member.next, typeof(*pos), member);
> 	     &pos->member != (head);
> 	     pos = n, n = list_entry(n->member.next, typeof(*n), member))
> 
> then what am I to think?

You won't catch me writing this kind of crap, so the question is moot.
Seriously, a comma operator? Admit it, you just expanded a marcro from
list.h by hand. Real people cannot write like that.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/