linux-kernel - Re: [PATCH 2/2] Fix possible leakage of blocks in UDF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070531174201.GB8392@cvg>
Date:	Thu, 31 May 2007 21:42:01 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Eric Sandeen <sandeen@...deen.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] Fix possible leakage of blocks in UDF

[Eric Sandeen - Wed, May 30, 2007 at 05:22:23PM -0500]
| Eric Sandeen wrote:
| 
| > Jan, something seems busted here.  I'm getting lockups when testing udf
| > on a single cpu with this last patch in place...
| > 
| > I think it's the BKL stumbling on itself.
| 
| To demonstrate, try this:
| 
| # BIGFILENAME=`seq -s '' 1 1000`
| # ln -s $BIGFILENAME foo
| 
| instant deadlock :(
| 
| -Eric
| 

Eric, could you please try the following:

1) declare the spinlock in the top of inode.c as

	DEFINE_SPINLOCK(udf_drop_lock);

2) replace in udf_drop_inode()

	kernel_lock -> spin_lock(&udf_drop_lock);
	kernel_unlock -> spin_unlock(&udf_drop_lock);

I'm not sure if it help but you may try ;)

		Cyrill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/