linux-kernel - Re: [PATCH 13/22] 2.6.22-rc3 perfmon2 : common core functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070531185323.GA10745@infradead.org>
Date:	Thu, 31 May 2007 19:53:24 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Stephane Eranian <eranian@....hp.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/22] 2.6.22-rc3 perfmon2 : common core functions

On Thu, May 31, 2007 at 08:43:14PM +0200, Andi Kleen wrote:
> > I think the perform backend for oprofile is the right way to go.
> > I'd even go further and say we should merge the perfom backend with
> > oprofile as the only user first, because a) the current perfom user
> > interface is a complete mess 
> 
> Can you suggest concrete criticism/improvements/alternative proposals to 
> Stephane then? 

Actually writing up a proposal for an alternate inferface is obviously
a lot of work, that I can't just do while reading a mail.  I've put
it on my todo list for the next weekends.

> > and can't be merged as-is and b) that
> > ensures the oprofile backend works perfectly and we can kill some
> > existing code in exchange.
> 
> Hmm, but at least for oprofile like functionality oprofile code seems
> much simpler. And it's not really bad code. I assume the user interface
> would change too.  I think it's better to let them coexist for some time.

People will want perfom and oprofile in the same kernel, and we'd better
allow useage at the same time, so I'd be very much in favour of having
just one backend.  Especially giving the huge amount of different
performance counters we have to support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/