linux-kernel - Re: [PATCH 02/06] Use menuconfig objects 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0705312152580.11140@yvahk01.tjqt.qr>
Date:	Thu, 31 May 2007 21:53:58 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Tilman Schmidt <tilman@...p.cc>
cc:	Andrew Morton <akpm@...ux-foundation.org>, kkeil@...e.de,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/06] Use menuconfig objects 4 - ISDN part 2/6
 (CONFIG_ISDN_I4L)


On May 31 2007 18:16, Tilman Schmidt wrote:
>Am 30.05.2007 21:38 schrieb Jan Engelhardt:
>> --- linux-2.6.22-rc3-git1.orig/drivers/isdn/Kconfig
>> +++ linux-2.6.22-rc3-git1/drivers/isdn/Kconfig
>> @@ -21,9 +21,7 @@ menuconfig ISDN
>>  
>>  if ISDN
>>  
>> -menu "Old ISDN4Linux"
>> -
>> -config ISDN_I4L
>> +menuconfig ISDN_I4L
>>  	tristate "Old ISDN4Linux (obsolete)"
>>  	---help---
>>  	  This driver allows you to use an ISDN-card for networking
>> @@ -44,8 +42,6 @@ if ISDN_I4L
>>  source "drivers/isdn/i4l/Kconfig"
>>  endif
>>  
>> -endmenu
>> -
>>  comment "CAPI subsystem"
>>  
>
>This results in a rather strange and inconsistent presentation in
>"make xconfig", with ISDN4Linux appearing as a subtree in the left
>pane but CAPI only visible in the right pane after selecting ISDN.

That's a gconfig/xconfig b^H missing feature.

>IMHO it looks much saner like this:

But then you'd still have to descend into ISDN4Linux to deactivate it.

> config ISDN_I4L
> 	tristate "Old ISDN4Linux (deprecated)"
> 	---help---
>@@ -44,12 +42,8 @@ if ISDN_I4L



	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/