linux-kernel - Re: [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070531200218.GB17143@linux-os.sc.intel.com>
Date:	Thu, 31 May 2007 13:02:18 -0700
From:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>, mingo@...e.hu,
	linux-kernel@...r.kernel.org, nanhai.zou@...el.com,
	asit.k.mallick@...el.com, keith.packard@...el.com,
	Yinghai Lu <yhlu.kernel@...il.com>
Subject: Re: [PATCH] x86_64 irq: check remote IRR bit before migrating level triggered irq (v2)

On Thu, May 31, 2007 at 07:29:43AM -0600, Eric W. Biederman wrote:
> Andi Kleen <ak@...e.de> writes:
> 
> > On Thursday 31 May 2007 13:34:21 Eric W. Biederman wrote:
> >> 
> >> On x86_64 kernel, level triggered irq migration gets initiated in the context
> >> of that interrupt(after executing the irq handler) and following steps are
> >> followed to do the irq migration.
> >
> > What's the confidence level in the patch? Is it a .22 candidate?
> 
> Yes.
> 
> I just ran it for a little while and nothing fell over, and level
> triggered irqs continued to migrate.  So it's not horribly broken.
> 
> Outside of implementation errors the worst case that can happen with
> this code is the current behavior, with a small slow down.
> 
> So since I can not reproduce the original problem I would appreciate
> an eyeball or two more just to make certain I reimplemented this
> correctly and didn't do anything stupid.   But I don't expect anything
> to be found.  The code is pretty straight forward.

Yes. We want this to get included in .22. We did extensive testing with
our patch before.  We will also do more tests with this version, however.

thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/