linux-kernel - Re: [PATCH resend] introduce I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070531154648.b21d9fe2.akpm@linux-foundation.org>
Date:	Thu, 31 May 2007 15:46:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jörn Engel <joern@...ybastard.org>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	David Chinner <dgc@....com>,
	Anton Altaparmakov <aia21@....ac.uk>,
	Al Viro <viro@....linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH resend] introduce I_SYNC

On Thu, 31 May 2007 16:25:35 +0200
Jörn Engel <joern@...ybastard.org> wrote:

> On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote:
> >
> > If we're going to do this then please let's get some exhaustive commentary
> > in there so that others have a chance of understanding these flags without
> > having to do the amount of reverse-engineering which you've been put through.
> 
> Done.  Found and fixed some bugs in the process.  By now I feal
> reasonable certain that the patch fixes more than it breaks.
> 

> 
> -- 
> Good warriors cause others to come to them and do not go to others.
> -- Sun Tzu
> 
> Introduce I_SYNC.
> 
> I_LOCK was used for several unrelated purposes, which caused deadlock
> situations in certain filesystems as a side effect.  One of the purposes
> now uses the new I_SYNC bit.

Do we know what those deadlocks were?  It's a bit of a mystery patch otherwise.

Put yourself in the position of random-distro-engineer wondering "should I
backport this?".

> Also document the various bits and change their order from historical to
> logical.

What a nice comment you added ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/