[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070531231354.GR20632@ca-server1.us.oracle.com>
Date: Thu, 31 May 2007 16:13:54 -0700
From: Mark Fasheh <mark.fasheh@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Nick Piggin <npiggin@...e.de>
Subject: Re: 2.6.22-rc3-mm1 - page_mkwrite() breakage
On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote:
> git-ocfs2.patch
Andrew, thanks for getting that back in there.
mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch broke ocfs2 shared
writable mmap. We hang on a page lock because ->page_mkwrite() is
being called with the page already locked:
+ /*
+ * For consistency in subsequent calls, make the nopage_page always
+ * locked.
+ */
+ if (unlikely(!(vma->vm_flags & VM_CAN_INVALIDATE)))
+ lock_page(nopage_page);
It wasn't previously being called with the page lock held, intentionally.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@...cle.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists