linux-kernel - Re: [PATCH 4/5] serial: convert early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070530215116.5e0abd57.akpm@linux-foundation.org>
Date:	Wed, 30 May 2007 21:51:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Andi Kleen" <ak@...e.de>, "Russell King" <rmk@....linux.org.uk>,
	"Bjorn Helgaas" <bjorn.helgaas@...com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250

On Wed, 30 May 2007 21:42:15 -0700 "Yinghai Lu" <yhlu.kernel@...il.com> wrote:

> On 5/30/07, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > On Wed, 30 May 2007 21:34:35 -0700 "Yinghai Lu" <yhlu.kernel@...il.com> wrote:
> >
> > > they will need
> > > diff --git a/include/asm-x86_64/io.h b/include/asm-x86_64/io.h
> > > index de2cd9a..e2d66de 100644
> > > --- a/include/asm-x86_64/io.h
> > > +++ b/include/asm-x86_64/io.h
> > > @@ -145,6 +145,19 @@ extern void early_iounmap(void *addr, unsigned long size);
> > >  extern void __iomem * ioremap_nocache (unsigned long offset, unsigned
> > > long size);
> > >  extern void iounmap(volatile void __iomem *addr);
> > >
> > > +#include <asm/pgtable.h>
> > > +#include <asm/fixmap.h>
> > > +
> > > +static inline void __iomem * fix_ioremap (unsigned idx, unsigned long phys)
> > > +{
> > > +       void __iomem * vaddr;
> > > +       set_fixmap_nocache(idx, phys & PAGE_MASK);
> > > +       vaddr = (void __iomem *)__fix_to_virt(idx);
> > > +       vaddr += phys & ~PAGE_MASK;
> > > +
> > > +       return vaddr;
> > > +}
> > > +
> >
> > I hope not - I just removed that inlined function.  It's too large and the
> > inclusion of pgtable.h in io.h causes all sorts of problems.
> >
> > This function should go into arch/.../mm/ioremap.c
> >
> agree, but need to keep
> 
> #include <asm/fixmap.h>

No, there's no need for that and it is undesirable.

> and will create dummy fixmap.h for arch that doesn't support fixmap

So's that.  If we avoid the inlined function we will avoid adding more
include requirements.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/