linux-kernel - Re: [PATCH] Introduce O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070601113840.813463db.sfr@canb.auug.org.au>
Date:	Fri, 1 Jun 2007 11:38:40 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Ulrich Drepper <drepper@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, mingo@...e.hu,
	torvalds@...ux-foundation.org, Chris Zankel <chris@...kel.net>
Subject: Re: [PATCH] Introduce O_CLOEXEC (take >2)

On Thu, 31 May 2007 16:20:21 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> > diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h
> > index c154b9d..b847741 100644
> > --- a/include/asm-generic/fcntl.h
> > +++ b/include/asm-generic/fcntl.h
> > @@ -48,6 +48,9 @@
> >  #ifndef O_NOATIME
> >  #define O_NOATIME	01000000
> >  #endif
> > +#ifndef O_CLOEXEC
> > +#define O_CLOEXEC	02000000	/* set close_on_exec */
> > +#endif
> >  #ifndef O_NDELAY
> >  #define O_NDELAY	O_NONBLOCK
> >  #endif
> 
> This will break xtensa, because that architecture (and only that
> architecture) doesn't include asm-generic/fcntl.h from asm/fcntl.h.

This also breaks Alpha (which uses 02000000 for O_DIRECT) and parisc
(which uses 02000000 for O_RSYNC).  So you ether need to choose a
different value or define O_CLOEXEC for those two architectures.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped