| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070601193703.GI7217@one.firstfloor.org> Date: Fri, 1 Jun 2007 21:37:03 +0200 From: Andi Kleen <andi@...stfloor.org> To: Christoph Hellwig <hch@...radead.org>, Andi Kleen <andi@...stfloor.org>, Rik van Riel <riel@...hat.com>, linux-kernel <linux-kernel@...r.kernel.org>, andrew.vasquez@...gic.com Subject: Re: [PATCH] quiet down swiotlb warnings On Fri, Jun 01, 2007 at 07:12:25PM +0100, Christoph Hellwig wrote: > On Fri, Jun 01, 2007 at 09:01:45PM +0200, Andi Kleen wrote: > > Bad idea imho. swiotlb mappings should always lead to printk by default > > because it is pretty dangerous. > > > > One possible solution for this I could think of would be to define a > > new pci_map_sg_couldfail() or similar that doesn't warn and use a weak > > fallback just calling pci_map_sg on other IOMMU implementations. > > pci_map_sg is defined to be failing when running out of ressources, which > is perfectly fine. We don't printk on kmalloc failures either (actually Actually we do as you point out. > in some cases which is highly annoying and leads people to stick a > __GFP_NOWARN into various places) An pci_map_sg failing typically leads to an IO error and we've always printk'ed those. Otherwise people will wonder why they get EIO. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists