linux-kernel - Re: [PATCH 2/3]i386: early init pgt for fix virtual addr in head.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1wsynxvlb.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 01 Jun 2007 14:34:24 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Andi Kleen" <ak@...e.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Greg KH" <gregkh@...e.de>, "Bjorn Helgaas" <bjorn.helgaas@...com>,
	"Vivek Goyal" <vgoyal@...ibm.com>,
	"linux kernel mailing list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3]i386: early init pgt for fix virtual addr in head.S

"Yinghai Lu" <yhlu.kernel@...il.com> writes:

> On 6/1/07, Eric W. Biederman <ebiederm@...ssion.com> wrote:
>> "Yinghai Lu" <yhlu.kernel@...il.com> writes:
>>
>> > early init pgt for fix virtual addr in head.S, so can use set_fixmap
>> > before setup_arch.
>> > otherwise set_fixmap_nocache will not work for i386
>> >
>> > Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>> > Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
>>
>> Hmm.  I'm wondering how my signed off by got on this one.
>> Maybe I did this at some point.
>>
>> In any case this patch looks wrong (unless I'm completely mistaken)
>> because it doesn't appear to handle PAE mode.
>>
>> Which is why I initialized the early page table in C, in my
>> last round of patches on this subject.
>>
>> If we don't know the page table format doing this kind of
>> thing is very difficult.
>
> it is from post for your usb debug port patch. so you have updated one for i386?
> and x86_64 is right?

Yes.  I posted it to lkml, and the virtualization list, on the 30th of April.
I thought you had seen that.

I don't mind you picking up the work, I have so many other things to do.
But I did post a working version.

It wasn't merged for 2.6.22 because it was so close to the merge window
and so much other code was already in Andi queue.

If need be I can dig it up again and repost.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/