[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0706011345220.4323@schroedinger.engr.sgi.com>
Date: Fri, 1 Jun 2007 13:47:23 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Jeremy Fitzhardinge <jeremy@...p.org>
cc: Srinivasa Ds <srinivasa@...ibm.com>, linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Srivatsa Vaddagiri <vatsa@...ibm.com>,
Dinakar Guniguntala <dino@...ibm.com>, pj@....com,
simon.derr@...l.net, clameter@...ulhu.engr.sgi.com,
rientjes@...gle.com
Subject: Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777
warning
On Fri, 1 Jun 2007, Jeremy Fitzhardinge wrote:
> I think this is a good example of why having to special-case kmalloc(0)
> is a bad idea. The original code was straightforward and, barring
> silliness, should be completely correct with npids==0. This new code
> does nothing other than make things more complex.
Hehe we got you. The code is indexing the pidarray allocated with
kmalloc(0). So it uncovered a latent bug. It only worked because SLAB gave
him 32 bytes and it now only works because SLUB give him 8. That is enough
to illegally index the first array element.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists