linux-kernel - [PATCH RT] enable interrupts in do_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1180740062.21781.53.camel@localhost.localdomain>
Date:	Fri, 01 Jun 2007 19:21:02 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: [PATCH RT] enable interrupts in do_page_fault for users.

Ingo,

To prevent scheduling while irqs disabled, I added a force to the
do_page_fault to enable interrupts.

The thing is, if the user faults at an address above PAGE_OFFSET. My
stupid program that I attached to my last email did just that:

  unsigned long *p = (void*)-1;

  *p = 0xbed;

where (void*)-1 is an address greater than PAGE_OFFSET.  If I changed
that address to (void*)1, the program still segfaulted, but I didn't get
the warning about scheduling while interrupts disabled. I even put in a
print to show if interrupts are disabled in do_page_fault before calling
force_sig_info, and with (void*)-1 they were, and with (void*)1 they
were not disabled.

This patch forces interrupts to always be enabled when entering the user
fault code. Maybe this should also be applied to mainline?

This solves the one issue with scheduling while irqs disabled.

-- Steve

Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Index: linux-2.6.21-rt9/arch/x86_64/mm/fault.c
===================================================================
--- linux-2.6.21-rt9.orig/arch/x86_64/mm/fault.c
+++ linux-2.6.21-rt9/arch/x86_64/mm/fault.c
@@ -476,6 +476,10 @@ bad_area:
 bad_area_nosemaphore:
 	/* User mode accesses just cause a SIGSEGV */
 	if (error_code & PF_USER) {
+
+		/* it's possible to have interrupts off here */
+		local_irq_enable();
+
 		if (is_prefetch(regs, address, error_code))
 			return;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/