linux-kernel - Re: [PATCH 2/5] console: console handover to preferred console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <465F6563.7060804@sun.com>
Date:	Thu, 31 May 2007 17:16:35 -0700
From:	Yinghai Lu <Yinghai.Lu@....COM>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <ak@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] console: console handover to preferred console

Andrew Morton wrote:
> On Thu, 31 May 2007 13:58:26 -0700
> Yinghai Lu <Yinghai.Lu@....COM> wrote:
> 
>> [PATCH 2/5] console: console handover to preferred console
>>
>> Signed-off-by: Yinghai Lu <yinghai.lu@....com>
>>
>> diff --git a/kernel/printk.c b/kernel/printk.c
>> index 0bbdeac..7b96cae 100644
>> --- a/kernel/printk.c
>> +++ b/kernel/printk.c
>> @@ -985,12 +1007,15 @@ void register_console(struct console *console)
>>  	if (!(console->flags & CON_ENABLED))
>>  		return;
>>  
>> -	if (bootconsole) {
>> +	if (bootconsole && (console->flags & CON_CONSDEV)) {
>>  		printk(KERN_INFO "console handover: boot [%s%d] -> real [%s%d]\n",
>>  		       bootconsole->name, bootconsole->index,
>>  		       console->name, console->index);
>>  		unregister_console(bootconsole);
>>  		console->flags &= ~CON_PRINTBUFFER;
>> +	} else {
>> +		printk(KERN_INFO "console [%s%d] enabled\n",
>> +		       console->name, console->index);
>>  	}
>>  
>>  	/*
> 
> What does this change do, and what is the reason for it??

for earlyprintk=ttyS0,9600 console=tty0 console=ttyS0,9600n8

the handover will happen from earlyser0 to tty0. but what we want is to ttyS0.

later with patch4,
console=tty0 console=uart8250,io,0x3f8,9600n8
will handover to ttyS0 instead of tty0.

Maybe can put above lines into commit log.

YH

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/