linux-kernel - 2.6.22-rc3-mm1: __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070602171425.GG5500@stusta.de>
Date:	Sat, 2 Jun 2007 19:14:25 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Martin Peschke <mp3@...ibm.com>
Cc:	linux-kernel@...r.kernel.org
Subject: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch 
shows why __attribute__((weak)) is harmful because you don't see if a 
required non-weak implemtation is missing:

In this case, the weak printk_clock() was renamed to timestamp_clock(), 
but the ARM and i386 implementations weren't renamed...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/