linux-kernel - Re: libata & no PCI: dma_[un]map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070604143005.1b0e3c66@the-village.bc.nu>
Date:	Mon, 4 Jun 2007 14:30:05 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	mroos@...ux.ee, linux-kernel@...r.kernel.org
Subject: Re: libata & no PCI: dma_[un]map_single undefined

> > CONFIG_PCI=n
> > CONFIG_ATA=m
> > 
> > This seems to be a valid configuration since libata can drive non-PCI 
> > devices too?

Yep.

> It really makes no sense to allow this on Sparc, there are no
> non-PCI Sparc ATA controllers.

There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the
Sparc platform I thought ?

> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b4a8d60..7d893a6 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -8,6 +8,7 @@ menuconfig ATA
>  	depends on BLOCK
>  	depends on !(M32R || M68K) || BROKEN
>  	depends on !SUN4 || BROKEN
> +	depends on !(SPARC64 && !PCI)


NAK - this is the wrong approach. PCI=n ATA=m should compile. Sparc is
not the only problem case. The DMA handling bits of libata are fairly
nicely split out but they are stuck in the same file and unconditionally
compiled in.

I'll have a poke at this when I get a bit of time if Jeff doesn't.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/