linux-kernel - Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070604075153.GB2074@localhost.localdomain>
Date:	Mon, 4 Jun 2007 15:51:53 +0800
From:	WANG Cong <xiyou.wangcong@...il.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Jeff Garzik <jeff@...zik.org>, Randy Dunlap <rdunlap@...otime.net>,
	Al Viro <viro@....linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	Chen Li-jun <cljun@...ou.edu.cn>,
	Wang Ya-gang <lazy_linux@....com>
Subject: Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

On Sun, Jun 03, 2007 at 11:59:26PM -0700, Jeremy Fitzhardinge wrote:
>WANG Cong wrote:
>> I just wonder, if a goto label is nested in a while/for/if/switch block, aligning it in
>> the first column maybe a bit ugly. (I know mostly it is not in any while/for/if/switch block.)
>>   
>
>In general goto labels are not scoped, so there's no point in pretending
>they are.  It might make sense to indent a label deeper if you've
>actually declared it local (__label__).
>
>    J

OK. Thank you. I will take your advice.

A new version of this patch will come  soon. ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/