linux-kernel - [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070604221257.GD5500@stusta.de>
Date:	Tue, 5 Jun 2007 00:12:57 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	Krzysztof Helt <krzysztof.h1@...pl>,
	Antonino Daplas <adaplas@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [RFC: 2.6 patch] drivers/video/pm3fb.c: possible cleanups

This patch contains the following possible cleanups:
- remove the empty pm3fb_setup() and corresponding code
- pm3fb_init() can become static

Signed-off-by: Adrian Bunk <bunk@...sta.de>

---

 drivers/video/pm3fb.c |   31 +------------------------------
 1 file changed, 1 insertion(+), 30 deletions(-)

--- linux-2.6.22-rc3-mm1/drivers/video/pm3fb.c.old	2007-06-04 22:49:25.000000000 +0200
+++ linux-2.6.22-rc3-mm1/drivers/video/pm3fb.c	2007-06-04 22:52:54.000000000 +0200
@@ -380,8 +380,6 @@ static void pm3fb_write_mode(struct fb_i
 /*
  * hardware independent functions
  */
-int pm3fb_init(void);
-
 static int pm3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
 {
 	u32 lpitch;
@@ -935,35 +933,8 @@ static struct pci_driver pm3fb_driver = 
 
 MODULE_DEVICE_TABLE(pci, pm3fb_id_table);
 
-#ifndef MODULE
-	/*
-	 *  Setup
-	 */
-
-/*
- * Only necessary if your driver takes special options,
- * otherwise we fall back on the generic fb_setup().
- */
-static int __init pm3fb_setup(char *options)
+static int __init pm3fb_init(void)
 {
-	/* Parse user speficied options (`video=pm3fb:') */
-	return 0;
-}
-#endif /* MODULE */
-
-int __init pm3fb_init(void)
-{
-	/*
-	 *  For kernel boot options (in 'video=pm3fb:<options>' format)
-	 */
-#ifndef MODULE
-	char *option = NULL;
-
-	if (fb_get_options("pm3fb", &option))
-		return -ENODEV;
-	pm3fb_setup(option);
-#endif
-
 	return pci_register_driver(&pm3fb_driver);
 }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/